Add support for custom attributes function #3198
Open
+194
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urdarinda
force-pushed
the
jatin/add-custom-attrs
branch
from
120cdd0 to
64bfb34
Compare
|
@ofekshenawa Please take a look at this one |
|
Can you please add some tests? |
Added tests for metrics and custom attributes |
urdarinda
force-pushed
the
jatin/add-custom-attrs
branch
from
0524dee to
b04e7ba
Compare
|
@ofekshenawa Added tests but something weird is happening with the tests. It was passing tests yesterday and failing now. It should only fail on 1.19 afaik because the metric sdk version I am using requires 1.20 and above ( not able to find a working version before that) |
urdarinda
force-pushed
the
jatin/add-custom-attrs
branch
from
fda6b07 to
f7d3f48
Compare
|
@ofekshenawa Fixed the tests, but it is failing on 1.19 ( the test setup for metrics require 1.20+) , before those not able to find test functions for metric testing. How can we proceed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to add custom attributes to metrics in order to give better context with the application.
Example,
I want to identify which API is responsible for calling this redis command and group by the calling API